Update pre-commit hooks #118
Conversation
sadikkuzu
commented
Sep 17, 2023
•
sadikkuzu
commented
- https://github.com/psf/black updating 23.3.0 -> 23.9.1
- https://github.com/pycqa/isort updating 5.11.5 -> 5.12.0
* https://github.com/psf/black updating 23.3.0 -> 23.9.1 * https://github.com/pycqa/flake8 updating 5.0.4 -> 6.1.0 * https://github.com/pycqa/isort updating 5.11.5 -> 5.12.0
There was a problem hiding this comment.
Thanks @sadikkuzu !
On another note, I think we should start using ruff here too @chrstnbwnkl and finally ditch flake8.
We're never running on any other platform Co-authored-by: Nils <[email protected]>
Let's at least use the .pre-commit-config.yaml's content, otherwise it'll (un)cache the current versions forever. Co-authored-by: Nils <[email protected]>
There was a problem hiding this comment.
Thanks for including ruff, I didn’t mean to make you do it, but do appreciate it:)
Only one more thing: can we include the config into the pyproject.toml and remove its dedicated config file? One of the few reasons why I don’t like flake8, they still don’t support that (or didn’t until last time I checked). Thanks!
|
It's my pleasure to have implemented the ruff part too:) Sure, yes, I totally agree with you about having a single configuration file. When I was looking up where flake8 configs are, I saw the setup.cfg file, and I mistakenly thought you were using separate files. I totally missed the existence of pyproject.toml. 😅 I'll make the necessary changes and move the configs there. 👍🏼 |
