Skip to content

Commit

Permalink
Merge pull request #4344 from corentin-soriano/fix_invisible_folder
Browse files Browse the repository at this point in the history
Fix invisible new created folder in personal space and avoid double jstree selection on creation.
  • Loading branch information
nilsteampassnet authored Sep 20, 2024
2 parents 021d11a + e0ba936 commit 186200e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions pages/items.js.php
Original file line number Diff line number Diff line change
Expand Up @@ -1928,6 +1928,9 @@ function(data) {
// Refresh list of folders
refreshVisibleFolders(true);
if ($('#form-folder-add').data('action') === 'add') {
// select new folder on jstree
$('#jstree').jstree('deselect_all');
$('#jstree').jstree('select_node', '#li_' + data.newId);
// Refresh tree
refreshTree(data.newId, true);
// Refresh list of items inside the folder
Expand Down
4 changes: 3 additions & 1 deletion sources/folders.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ private function rebuildFolderTree($user_is_admin, $title, $parent_id, $isPerson
$tree = new NestedTree(prefixTable('nested_tree'), 'id', 'parent_id', 'title');
$tree->rebuild();

SessionManager::addRemoveFromSessionArray('user-accessible_folders', [$newId], 'add');
// Update session visible flolders
$sess_key = $isPersonal ? 'user-personal_folders' : 'user-accessible_folders';
SessionManager::addRemoveFromSessionArray($sess_key, [$newId], 'add');

if ($user_is_admin === 0) {
$this->updateUserFolderCache($tree, $title, $parent_id, $isPersonal, $user_id, $newId);
Expand Down

0 comments on commit 186200e

Please sign in to comment.