2.1.25.2

Fix for case where an array could contain an empty value
nilsteampassnet · Jan 30, 2016 · aa4fb01 · aa4fb01
1 parent ebe6233
commit aa4fb01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sources/main.functions.php b/sources/main.functions.php
@@ -417,7 +417,7 @@ function identifyUserRights($groupesVisiblesUser, $groupesInterditsUser, $isAdmi
             "SELECT * FROM ".prefix_table("roles_title")."
             ORDER BY title ASC");
         foreach ($rows as $record) {
-            if (!in_array($record['id'], $tmp)) {
+            if (!empty($record['id']) && !in_array($record['id'], $tmp)) {
                 array_push($tmp, $record['id']);
             }
         }

diff --git a/sources/roles.queries.php b/sources/roles.queries.php
@@ -230,8 +230,8 @@
             $previous = 1;
 
             //count nb of roles
-			if (empty($_SESSION['fonction_id'])) $where = "";
-			else  $where = " WHERE id IN (".str_replace(";", ",", $_SESSION['fonction_id']).")";
+            if (empty($_SESSION['fonction_id'])) $where = "";
+            else  $where = " WHERE id IN (".array_filter(str_replace(";", ",", $_SESSION['fonction_id'])).")";
             DB::query("SELECT * FROM ".prefix_table("roles_title").$where);
             $roles_count =  DB::count();
             if ($roles_count > $display_nb) {
@@ -252,7 +252,7 @@
             //Display table header
             $rows = DB::query(
                 "SELECT * FROM ".prefix_table("roles_title").
-				$where."
+                $where."
                 ORDER BY title ASC".$sql_limit);
             foreach ($rows as $record) {
                 if ($_SESSION['is_admin'] == 1  || ($_SESSION['user_manager'] == 1 && (in_array($record['id'], $my_functions) || $record['creator_id'] == $_SESSION['user_id']))) {