-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a theme to vscode-nim? #142
base: main
Are you sure you want to change the base?
Conversation
This reverts commit b6f7193.
Theme is a work in progress. It is provided as an example.
Restore readme.md
Why this needs to be part of the extension though? |
There is no strict need for one or more themes to be part of the standard Nim extension. However, one part of this extension that really IS needed - and already present - is the correct recognition of Nim tokens, including indentation and brackets. Adding themes that more fully translate this vital job into visuals for developers helps complete this core task. Therefore, this PR intended to be a) small, b) relatively unimportant in itself, and c) usefully support a much more important job. |
Does this do the tokenization properly? A good test case is system.nim after line 145: proc new*[T](a: var ref T, finalizer: proc (x: ref T) {.nimcall.}) {.
magic: "NewFinalize", noSideEffect, deprecated: "pass a finalizer of the 'proc (x: T) {.nimcall.}' type".} Messes up my current tooling because of the pragma syntax used inside a string literal inside a pragma. |
Araq, If the former, then vscode with vscode-nim should already accommodate you? If the latter, that's (at least) a syntax file issue; changing only the theme will not help. |
Yes, this one. There is not much complexity going on here, just tokenize as always inside |
@AMSwift73 can you provide some screenshots showing how this actually helps? Bonus points if you also make the PR so it doesnt modify existing lines but only your actual changes |
@Araq doesnt yours look like this? |
This follows up on my earlier issue report and on the Nim forum thread https://forum.nim-lang.org/t/12697.
Proposal: Add nim-ready themes to the vscode-nim extension. The theme offered is still in beta and needs review, but it does:
I apologize for the messy commit history; I'm new to git, github, and the github desktop app.
readme.md should be unchanged, package.json should only have a block added pointing to a theme (near end of file), and the only significant addition is one theme in a new "themes" folder.