parameterTransform handles multivariate user dists, with a warning#1532
Merged
Conversation
Member
Author
|
@perrydv Only addressing your comment about I just checked, and those changes (addressing this issue) appear to still be on branch |
Member
Author
|
My previous comment was intended for NCT issue 567, and has been repeated there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it all.
In such cases, no transformation is applied to the node(s) following the multivariate user-defined distribution, and an informative warning is issued. In addition, there's a new system-level option (
parameterTransformWarnUserDists) which can turn off the warning.I did some a quick test, and I believe this works as intended.
Anyone else is welcomed to modify the warning message, if they want.