Add derived quantities info to manual#1567
Merged
Merged
Conversation
Set up roxygen alias for deriv quant methods. Tweak printing of deriv quants.
Member
|
@paciorek Thanks for the opportunity to review this. I have some suggestions and comments below. In
|
Contributor
Author
|
Thanks for the careful read; I've fixed all this to your specification. Except that regarding line 120, it is the case that by default only the samples are returned. It's just that in the example code, And as far as lower-case comments, my understanding is that upper case is generally the standard amongst developers, Given no other comments I will probably merge this in soon. We can always make subsequent changes on |
…o deriv_quant_manual
Member
|
@paciorek Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a section to the MCMC chapter of the manual. It also mentions derived quantities in various places in the manual (the lightning intro and various sections of the MCMC chapter).
It's basically the content in Daniel's vignette, but I've rearranged and reworded the content a bit, added some framing text, as well as shortening somewhat.
I think it's in decent shape, so while I welcome comments and am sure there are places that could be improved, commenting may not be a high priority, though I expect @danielturek will want to take a look when he has a chance.
I'm making this a PR for comments only -- I've stopped the CI as there is nothing code-wise in here.