Pg simple update#1569
Merged
Merged
Conversation
1. Fixed when Design Matrix is initialized 2. Small bug of an empty inflationNodes 3. Added a warning for when infinite design matrix values are constructed.
Contributor
|
Sorry about the delay in looking at this. I have some questions.
|
Contributor
Author
|
@paciorek Thanks. I'll make the suggested changes this afternoon and merge into devel if there are no conflicts etc. |
-when inflation nodes are computed (outside of check) -error out if an infinite design matrix value is found on the first round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes:
inflationNodesto avoid a small error whencheck = FALSE.initializeX=FALSEif a design matrix is passed@paciorek Should we put a full stop if infinite values are detected in the design matrix instead of a warning?
Does it make sense to allow the user to override this warning? Currently
infiniteOkayis a list input. Better name? I need to add it documentation still.