Make rmnorm_inv_ld match rmnorm_chol and fix recycling rule#1586
Merged
Conversation
…s match uncompiled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
rmnorm_inv_ldso that it matchesrmnorm_cholin the case of a precision parameterization. In fact,rmnorm_inv_ldnow callsrmnorm_chol.nimArr_rmnorm_cholandnimArr_rmnorm_inv_ld(the versions used from compiled code) so that they use the same recycling rule behavior for themeanparameter as uncompiled calls (toC_rmnorm_cholandC_rmnorm_inv_ld). Previously they did not do so, and that discrepancy was noticed during work on item (1).In addition tests are added to
test-ADdmnorm.