Conversation
Member
Author
|
@paciorek Is there a goal of getting testing to start passing again on core nimble (devel branch)? |
Contributor
|
I had been planning on merging the |
Contributor
|
Ok, this is passing now. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses NCT issue 591.
This PR adds an
iterationTotalcounter to the core MCMC run method, which tracks the total number of MCMC iterations executed (since the last call with reset = TRUE). This produces a more logical schedule of saving samples, in particular when the thin interval is not 1 and an MCMC run is continued using reset=FALSE.See what testing turns up. I think it's all correct, but I only did very modest testing myself.