Skip to content

Comments

Fixed docs#209

Merged
jgraef merged 2 commits intoalbatrossfrom
janosch/fix-linked-list
Dec 17, 2020
Merged

Fixed docs#209
jgraef merged 2 commits intoalbatrossfrom
janosch/fix-linked-list

Conversation

@jgraef
Copy link
Contributor

@jgraef jgraef commented Dec 16, 2020

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I have resolved any merge conflicts.

What's in this pull request?

This builds upon #207

This fixes issues in the doc-strings in nimiq_collections::linked_list. The doc-strings there use examples with std::collections::LinkedList, which removed some features. I changed the relevant doc-strings to import nimiq_collections::linked_list::LinkedList.

In future we should remove our own LinkedList, and use the std::collections one. But UniqueLinkedList depends on it and needs to be rewritten maybe. Altogether this with LimitHashSet is only used in a few places.

Sergio Valverde and others added 2 commits December 8, 2020 18:19
@jgraef jgraef merged commit 5fd4848 into albatross Dec 17, 2020
@jgraef jgraef deleted the janosch/fix-linked-list branch December 17, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant