Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for Nodejs 6.x #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hlapp
Copy link
Collaborator

@hlapp hlapp commented Feb 5, 2018

Running under Nodejs 6.x requires upgrading serialport to 6.x.x, which includes API and behavior changes compared to the 2.x.x version usable under Nodejs 0.12.x and up to Nodejs 4.x.

The dependency on the ninjablocks/node-serialport fork fails to install on nodejs 4.x,
and likely would on 0.12.x as well.

Also increments version, and adds minimum nodejs version according to serialport
declaration. This is to distinguish from previous version.
Also includes the code changes necessary to continue working under
Nodejs 6.x.
@elliots
Copy link
Member

elliots commented Feb 5, 2018

Wow, thanks @hlapp ... I assume this is a breaking change for people using ancient node?
Do you know if the rest of the ninja node app work ok in Node 0.12+?

@hlapp
Copy link
Collaborator Author

hlapp commented Feb 5, 2018

I assume this is a breaking change for people using ancient node?

Yes, the breaking change comes from serialport, and for this change ancient include Nodejs 4.x. (Nodejs 4.x will work with serialport 4.x, but not higher, according to serialport documentation.)

Do you know if the rest of the ninja node app work ok in Node 0.12+?

Yes, I have it running now under Nodejs 6.x. Also requires hlapp/ninjablocks-utilities@3c6493b.

For 0.12.x <= Nodejs <= 4.x, you will need #3 here, and the pull requests I have made for ninjablocks/utilities. Also changes here hlapp/ninjablocks-client@master-local. I use https://github.com/hlapp/ninja-mqtt to communicate via MQTT.

@elliots
Copy link
Member

elliots commented Feb 5, 2018

@hlapp , i've sent you write access invitation to this repo and utilities. If you accept, feel free to accept your own pull requests :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants