Use sizeof(uin32_t) when configuring HCI command packet #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch configures the uim-sysfs daemon to use the sizeof(uint32_t) statement when configuring the HCI command packet, specifically the packet payload length field. The bit width of 'unsigned long' can differ between 32-bit and 64-bit platforms (specifically: 4 bytes for 32-bit, 8 bytes for 64-bit) and result in an incorrect payload length in the HCI command packet header. This causes the Bluetooth chip to not respond to the command, resulting in the chip not being configured at all and ultimately non-functional Bluetooth. So, the lesson here is to ALWAYS USE EXPLICIT TYPE SIZES if the bit width of the type matters, as it does here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch configures the uim-sysfs daemon to use the sizeof(uint32_t) statement when configuring the HCI command packet, specifically the packet payload length field. The bit width of 'unsigned long' can differ between 32-bit and 64-bit platforms (specifically: 4 bytes for 32-bit, 8 bytes for 64-bit) and result in an incorrect payload length in the HCI command packet header. This causes the Bluetooth chip to not respond to the command, resulting in the chip not being configured at all and ultimately non-functional Bluetooth.
So, the lesson here is to ALWAYS USE EXPLICIT TYPE SIZES if the bit width of the type matters, as it does here.