Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime detection of Mono #126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

linnet
Copy link

@linnet linnet commented Apr 8, 2014

Currently, the Mono 4 build of Ninject is required to run Ninject on recent versions of Mono. This complicates the use indicated by the questions in newsgroups, Stack Overflow. In addition, using NuGet for a solution running on Mono is out of the question.

This pull request attempts to eliminate the need for the Mono 4 build by replacing compile time directives with runtime detection.

Mono 2 and 3.5 are not affected.

@remogloor
Copy link
Member

can't apply atm
silverlight does not compile anymore

@linnet
Copy link
Author

linnet commented May 6, 2014

@remogloor I can see from the 4.0.0 branch that support for the older versions of Mono (< 4.0) has been removed.

What is your attitude towards this pull request? If it is deemed feasible I will gladly redo the changes to target the 4.0.0 branch instead.

@remogloor
Copy link
Member

Ninject 4.0 will drop support for .NET < 4.0 (and therefore Mono < 4.0)
support so that we can use concurrent collections. For .NET 3.5 application
we will keep bugfixing Ninject 3.x but not add any new features.

2014-05-06 10:35 GMT+02:00 Jesper Kamstrup Linnet [email protected]
:

@remogloor https://github.com/remogloor I can see from the 4.0.0 branch
that support for the older versions of Mono (< 4.0) has been removed.

What is your attitude towards this pull request? If it is deemed feasible
I will gladly redo the changes to target the 4.0.0 branch instead.


Reply to this email directly or view it on GitHubhttps://github.com//pull/126#issuecomment-42278352
.

@linnet
Copy link
Author

linnet commented May 7, 2014

Ok. But will runtime detection of Mono (as implemented in this pull request) be interesting to you in order to avoid a separate Mono build? It would make a lot of sense for our project running under .NET on Windows and Mono on Linux.

@ygormutti
Copy link

I would like to see this pull request merged. I'm working on a project which developers use Linux and Windows and we use NuGet for every external dependency, except for Ninject, because of this issue.

As you can see, the Coinium project isn't using Ninject anymore. If the build for Mono doesn't work well on Windows I'll have to stop using Ninject too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants