Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for useless ConstructorArgument. #402

Open
wants to merge 1 commit into
base: Release3.3.5
Choose a base branch
from

Conversation

lsoft
Copy link

@lsoft lsoft commented Jul 5, 2023

I'd want to add to Ninject a feature for checking for an useless ConstructorArgument and fail the resolution process if it found.

I have prototyped the PR, please take a look. I understand that this PR is not ready to merge, I want to ask maintainers for a remarks.

(If it will be approved, I would suggest to enable the new setting to be True by default in 4.0.0 release)

Side note: I'd created my branch from 3.3.6 tag commit, and I had a difficulty when choosing a target branch for PR. Please change the target branch if I pick the wrong one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant