Add optional Redis analysis caching #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazywam
changed the title
ninoseki
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we're using eml-analzyer to dissect various eml files and it's working great, thanks!
One issue we have is that files are in various other systems and downloading and uploading them one by one is pretty painful.
As far as i know, right now there is no possibility of directly uploading a file and displaying it from another origin (mainly due to the single-page-application architecture).
This PR proposes an additional component that saves/caches the result eml analysis and allows users to easily query view and query the database on page on using the anchor link(
#). An example "analysis link" looks like this: https://eml.service/#2c6077cb96da133a6c100f7149b31a963e7a49553d7c93c1ae0481249e262a8dRedis is both completely optional and opt-in so it shouldn't cause any problem for existing users. Nevertheless, I completely understand you don't want to merge this but since I've already added this in our instance you might be interested in it as well ^^