Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: CoordinateImage API #1090

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Conversation

effigies
Copy link
Member

Along with #1084, replaces #1056.

Starting with some basic implementations in test directory. Next step is to write some API unit tests to clarify expected behavior and code some specific implementations toward those tests.

Will close #1056 once I've taken all comments into account.

@pep8speaks
Copy link

pep8speaks commented Feb 21, 2022

Hello @effigies, Thank you for updating!

Line 34:1: F811 redefinition of unused 'Recoder' from line 33
Line 35:1: F811 redefinition of unused 'warn' from line 22

To test for issues locally, pip install flake8 and then run flake8 nibabel.

Comment last updated at 2022-08-31 00:48:00 UTC

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Patch coverage: 58.07% and project coverage change: -0.83% ⚠️

Comparison is base (4e7ad07) 92.19% compared to head (6c2407d) 91.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   92.19%   91.36%   -0.83%     
==========================================
  Files          99      101       +2     
  Lines       12458    12734     +276     
  Branches     2560     2621      +61     
==========================================
+ Hits        11486    11635     +149     
- Misses        648      762     +114     
- Partials      324      337      +13     
Files Changed Coverage Δ
nibabel/coordimage.py 36.60% <36.60%> (ø)
nibabel/cifti2/caretspec.py 58.19% <58.19%> (ø)
nibabel/arrayproxy.py 100.00% <100.00%> (ø)
nibabel/gifti/gifti.py 93.26% <100.00%> (ø)
nibabel/pointset.py 99.16% <100.00%> (+0.38%) ⬆️
nibabel/xmlutils.py 89.74% <100.00%> (+8.34%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the enh/coordimage_api branch 6 times, most recently from ef81d35 to 23e34f9 Compare February 25, 2022 16:26
@effigies effigies force-pushed the enh/coordimage_api branch 2 times, most recently from e8f9280 to 82eb277 Compare September 20, 2023 17:59
@effigies effigies force-pushed the enh/coordimage_api branch 2 times, most recently from 862a0c4 to f0c6a6b Compare September 22, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants