Add active-window-* as options for floating window relative-to rule#3465
Open
contagnas wants to merge 1 commit intoniri-wm:mainfrom
Open
Add active-window-* as options for floating window relative-to rule#3465contagnas wants to merge 1 commit intoniri-wm:mainfrom
contagnas wants to merge 1 commit intoniri-wm:mainfrom
Conversation
Author
|
somewhat related: #978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
"active-window-*"options to theRelativeToenum fordefault-floating-position. These position the new floating window relative to the currently active window. My use case to emulating window parenting for applications` that don't support it, but I could imagine other uses as well.Demo:
2026-02-16_11-55-53.mp4
If there is no active window the new window goes to the center of the screen.
Considered some alternative approaches, because IMO this enum is a little bloated after this change:
default-floating-position-relative-to-active-windowthat would accept the samerelative-tooptionsbut just adding these to the enum seems more straightforward and understandable.