Update environment import command in niri-session#3495
Open
Zamanhuseyinli wants to merge 1 commit intoniri-wm:mainfrom
Open
Update environment import command in niri-session#3495Zamanhuseyinli wants to merge 1 commit intoniri-wm:mainfrom
Zamanhuseyinli wants to merge 1 commit intoniri-wm:mainfrom
Conversation
Since systemctl's import-environment support is now marked as deprecated and therefore gives a warning, I wanted to make such a correction so that the warning screen disappears, but since systemctl does not support import-environment directly anymore, I think it makes more sense to use only dbus or use systemctl in accordance with its new format.
Member
|
No we are not doing these hacks just to "hide a warning" |
Author
|
This isn't a hack or anything; it's a technical method for passing necessary variables using xargs. |
Author
|
I added this for compatibility reasons, not just as a warning. |
|
@YaLTeR i think denying it is just waiting for it to bite you later on when it breaks something. this is no longer a supported method by systemd. |
Contributor
|
But it still works, no? Also I prefer it over some hacky bash scripts chaining this PR is proposing. |
Author
|
Yes, it works, and yes, it's more technical than hacky methods in my opinion, that's why I wanted to add that.Instead of unnecessary scripting clutter, you can use simpler methods like these. |
Member
|
i'm happy to wait until it does bite me later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since systemctl's import-environment support is now marked as deprecated and therefore gives a warning, I wanted to make such a correction so that the warning screen disappears, but since systemctl does not support import-environment directly anymore, I think it makes more sense to use only dbus or use systemctl in accordance with its new format.