input-method-v1: track/render popups and adapt virtual keyboard integration for new Smithay API#3543
Draft
WantenMN wants to merge 2 commits intoniri-wm:mainfrom
Draft
input-method-v1: track/render popups and adapt virtual keyboard integration for new Smithay API#3543WantenMN wants to merge 2 commits intoniri-wm:mainfrom
WantenMN wants to merge 2 commits intoniri-wm:mainfrom
Conversation
9c40698 to
60f06b7
Compare
|
Does this resolve #3274? |
Member
|
I would note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds end-to-end handling for
input-method-v1popups (IME candidate/panel surfaces) and updates niri's virtual keyboard integration to match current Smithay behavior.What changed
InputMethodV1ManagerStateinitialization and storage in compositor state.InputMethodV1HandlerinState:new_popup,popup_repositioned,dismiss_popup),input-method-v1popup surfaces in the output render pass.input-method-v1popup commits.protocols/virtual_keyboard.rsto delegate to Smithay's current virtual keyboard manager flow.Why
With the current Smithay stack, niri needs explicit
input-method-v1popup management to correctly place and render IME candidate surfaces and to ensure redraws happen when those surfaces commit.In parallel, virtual keyboard request handling is now provided inside Smithay, so the previous custom event bridging in niri is no longer the right integration point.
Merge dependency
This PR depends on Smithay changes and should only be merged after: