Skip to content

Conversation

@alonisser
Copy link
Collaborator

please review this, this isn't minor

major changes:

all app development is contained in app folder
various build and dev tasks: such as:
grunt serve for local dev (with livereload),
grunt build to create a minfied, revvyed, concated, optimized, cleaned from console.log etc.. dist folder and automatic deploy to gh-pages (also an option for build without deploy)

Updated readme with instructions for usage and setup

most tests fixed (not all yet) to use updated casperjs version

@florpor
Copy link
Collaborator

florpor commented Feb 3, 2014

Sorry it took me so long to look at this, but it looks great!
Had a bit of a hard time configuring, mostly cuz i had no idea what gruntjs and bower were, but it's not actually hard.
Should add "npm install -g bower" to .travis.yml to get travis to not error out.
Great stuff

@alonisser
Copy link
Collaborator Author

I'll fix travis.. thanks @florpor

Twitter:@alonisser https://twitter.com/alonisser
LinkedIn Profile http://www.linkedin.com/in/alonisser
Facebook https://www.facebook.com/alonisser
_Tech blog:_4p-tech.co.il/blog
_Personal Blog:_degeladom.wordpress.com
Tel:972-54-6734469

On Mon, Feb 3, 2014 at 12:34 PM, florpor [email protected] wrote:

Sorry it took me so long to look at this, but it looks great!
Had a bit of a hard time configuring, mostly cuz i had no idea what
gruntjs and bower were, but it's not actually hard.
Should add "npm install -g bower" to .travis.yml to get travis to not
error out.
Great stuff

Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33939754
.

@niryariv
Copy link
Owner

sorry it's taking me so long, been swamped at work/home. i still havent managed to get this running - i expect it's a noob question, but i get this:

niryariv$ grunt build
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'load-grunt-tasks'
Warning: Task "build" not found. Use --force to continue.

Aborted due to warnings.

@florpor
Copy link
Collaborator

florpor commented Feb 10, 2014

@niryariv do a 'npm install' in the folder to install prerequisites listed in package.json

@alonisser
Copy link
Collaborator Author

Any news on this? sepcific problems?

@niryariv
Copy link
Owner

Yeah, I wanted to discuss this with you when we meet but it doesn't seem to work out :)

I like the code, but concerned that it makes the learning curve steeper - much of the contributions on the client side were done by people who put in a couple hours' CSS or JS work. This requires setting up npm/grunt/bower just in order to build the code locally, so makes it harder to contribute new patches.

I realize this is the right way to go in the long run, but since the client side is so small at this stage and so easy to build (just opening index.html in a browser works, without even running a local server), I think it'll be better to keep it simple at this point.

That said I'm open to hear contradicting opinions from everyone: @alonisser @florpor @shevron @oreniko let me know what you think..

@alonisser
Copy link
Collaborator Author

I think every serious front end developer ourdays work with this kind of
tools on a daily basis. I can setup instructions in the readme for that. I
believe that later is harder and we should start adopting good practices in
our (going to be) growing open source project. besides,. without npm
install, grunt, etc the commiter cant run the tests locally.. and we sure
want them to do so..

Twitter:@alonisser https://twitter.com/alonisser
LinkedIn Profile http://www.linkedin.com/in/alonisser
Facebook https://www.facebook.com/alonisser
_Tech blog:_4p-tech.co.il/blog
_Personal Blog:_degeladom.wordpress.com
Tel:972-54-6734469

On Wed, Mar 26, 2014 at 3:53 PM, Nir Yariv [email protected] wrote:

Yeah, I wanted to discuss this with you when we meet but it doesn't seem
to work out :)

I like the code, but concerned that it makes the learning curve steeper -
much of the contributions on the client side were done by people who put in
a couple hours' CSS or JS work. This requires setting up npm/grunt/bower
just in order to build the code locally, so makes it harder to contribute
new patches.

I realize this is the right way to go in the long run, but since the
client side is so small at this stage and so easy to build (just opening
index.html in a browser works, without even running a local server), I
think it'll be better to keep it simple at this point.

That said I'm open to hear contradicting opinions from everyone:
@alonisser https://github.com/alonisser @florporhttps://github.com/florpor
@shevron https://github.com/shevron @Orenikohttps://github.com/Orenikolet me know what you think..

Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-38685363
.

@florpor florpor force-pushed the master branch 3 times, most recently from 576a93a to 21f806a Compare September 15, 2014 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants