-
Notifications
You must be signed in to change notification settings - Fork 15
Major folder regorganization, Automatic build and deploy to gh-pages, Fixed some of the testing #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Sorry it took me so long to look at this, but it looks great! |
|
I'll fix travis.. thanks @florpor Twitter:@alonisser https://twitter.com/alonisser On Mon, Feb 3, 2014 at 12:34 PM, florpor [email protected] wrote:
|
|
sorry it's taking me so long, been swamped at work/home. i still havent managed to get this running - i expect it's a noob question, but i get this: |
|
@niryariv do a 'npm install' in the folder to install prerequisites listed in package.json |
|
Any news on this? sepcific problems? |
|
Yeah, I wanted to discuss this with you when we meet but it doesn't seem to work out :) I like the code, but concerned that it makes the learning curve steeper - much of the contributions on the client side were done by people who put in a couple hours' CSS or JS work. This requires setting up npm/grunt/bower just in order to build the code locally, so makes it harder to contribute new patches. I realize this is the right way to go in the long run, but since the client side is so small at this stage and so easy to build (just opening index.html in a browser works, without even running a local server), I think it'll be better to keep it simple at this point. That said I'm open to hear contradicting opinions from everyone: @alonisser @florpor @shevron @oreniko let me know what you think.. |
|
I think every serious front end developer ourdays work with this kind of Twitter:@alonisser https://twitter.com/alonisser On Wed, Mar 26, 2014 at 3:53 PM, Nir Yariv [email protected] wrote:
|
…il subscription functionality
576a93a to
21f806a
Compare
please review this, this isn't minor
major changes:
all app development is contained in app folder
various build and dev tasks: such as:
grunt servefor local dev (with livereload),grunt buildto create a minfied, revvyed, concated, optimized, cleaned from console.log etc.. dist folder and automatic deploy to gh-pages (also an option for build without deploy)Updated readme with instructions for usage and setup
most tests fixed (not all yet) to use updated casperjs version