Fix/python deps #189
Fix/python deps #189
Conversation
| @@ -43,18 +43,23 @@ async def get_colormap( | |||
|
|
|||
| ::kwarg num_values int Number of values to generate in the colormap | |||
| """ | |||
| if stretch_range is None: | |||
| stretch_range_arg: list[int] = [0, 10] | |||
There was a problem hiding this comment.
Is there any reason for this particular default value? I am wondering if it's better to have a default here, or just require a parameter and explicitly fail when it's not supplied.
There was a problem hiding this comment.
It was a quick guess based on the datasets I'm familiar with! Should we fail with a 400 bad request?
There was a problem hiding this comment.
Some 4xx error for sure - doesn't FastAPI already return the appropriate error if we remove Optional from the parameter and it's missing from the request?
I'd say that not having a default sounds safer, just because the value is purely dependent on the data domain so in most cases it should be explicitly provided anyway - and presumably if some client code was forming requests incorrectly (e.g. with a typo in the stretch_range parameter name), this could lead to confusing behaviour where the default would be used and the tileserver would return tiles with incorrect colours but that would be difficult to spot.
|
|
||
| @validator("eael_days") | ||
| @field_validator("eael_days") |
There was a problem hiding this comment.
While we're at it - was the reason for keeping this quirk fix since this was first released because it was too time consuming to recalculate the raw data?
Bumping dependency versions in line with nismod/irv-jamaica#204