Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch narrative config errors in store #344

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

willu47
Copy link
Member

@willu47 willu47 commented Apr 2, 2019

Closes #342

Unsure as to whether store.py is the best location for these error messages. These types of issues should be caught in configuration validation (see also #343).

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #344 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   70.34%   70.41%   +0.07%     
==========================================
  Files          59       59              
  Lines        5119     5125       +6     
  Branches      608      610       +2     
==========================================
+ Hits         3601     3609       +8     
+ Misses       1426     1425       -1     
+ Partials       92       91       -1
Flag Coverage Δ
#javascript 70.41% <100%> (+0.07%) ⬆️
#python 78.38% <100%> (+0.07%) ⬆️
Impacted Files Coverage Δ
src/smif/data_layer/store.py 95.76% <100%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aab98...0f79e0c. Read the comment docs.

Copy link
Member

@tomalrussell tomalrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing errors from the store seems reasonable - for the larger validation story we may want to catch and log them as we scan through the config.

@tomalrussell tomalrussell merged commit e25951d into nismod:master Apr 11, 2019
@willu47 willu47 deleted the issue-342 branch April 11, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants