-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release smif v1.1 #369
Merged
Merged
Release smif v1.1 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Issue #334
Added two layers of set operations in the DecisionManager and DecisionModule Consider set of all interventions $I$ Set of planned interventions $P \subset I$ Available interventions $A = P \cap I$ Decisions at time t $D_t \subset A - D_{t-1}$
Co-Authored-By: willu47 <[email protected]>
Decision module may access available interventions
Fix/write empty state
Add section on adding a pre-specified planning strategy to docs
…e results available
Now requires smif list <-c/--complete>
…rnal() for outputs with ndims>1
…ilability of quieried output as well as dimensionality Issue #359
Include style niggles: - docstring parameter description on next line - prefer raising relevant errors to assertions - avoid abbrev.s in param. names (sec_model_name > model_name)
I359 programmatically query results
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 70.41% 71.09% +0.67%
==========================================
Files 59 60 +1
Lines 5125 5342 +217
Branches 610 661 +51
==========================================
+ Hits 3609 3798 +189
- Misses 1425 1448 +23
- Partials 91 96 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains work on the decision module and access to results.
Decisions
#333 - DecisionModule now handles the state of the system of systems correctly; refactored pre-spec planning out of DecisionModule
#334 - Results_Handle provides read-only access to state
#345 - Can read and write empty state to and from store without errors
#356 - Added documentation on how to use pre-specified planning
Results #350
#351 - Find out model runs which have results available
#352 - Identify missing results
(Forthcoming)
#359 - Programmatically access results