Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release smif v1.1 #369

Merged
merged 72 commits into from
May 7, 2019
Merged

Release smif v1.1 #369

merged 72 commits into from
May 7, 2019

Conversation

willu47
Copy link
Member

@willu47 willu47 commented May 3, 2019

This release contains work on the decision module and access to results.

Decisions

#333 - DecisionModule now handles the state of the system of systems correctly; refactored pre-spec planning out of DecisionModule
#334 - Results_Handle provides read-only access to state
#345 - Can read and write empty state to and from store without errors
#356 - Added documentation on how to use pre-specified planning

Results #350

#351 - Find out model runs which have results available
#352 - Identify missing results

(Forthcoming)
#359 - Programmatically access results

willu47 and others added 30 commits March 27, 2019 17:10
Added two layers of set operations in the DecisionManager and DecisionModule

Consider set of all interventions $I$
Set of planned interventions $P \subset I$
Available interventions $A = P \cap I$
Decisions at time t $D_t \subset A - D_{t-1}$
Decision module may access available interventions
Add section on adding a pre-specified planning strategy to docs
Now requires smif list <-c/--complete>
fcooper8472 and others added 21 commits April 26, 2019 13:48
…ilability of quieried output as well as dimensionality

Issue #359
Include style niggles:
- docstring parameter description on next line
- prefer raising relevant errors to assertions
- avoid abbrev.s in param. names (sec_model_name > model_name)
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #369 into master will increase coverage by 0.67%.
The diff coverage is 88.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   70.41%   71.09%   +0.67%     
==========================================
  Files          59       60       +1     
  Lines        5125     5342     +217     
  Branches      610      661      +51     
==========================================
+ Hits         3609     3798     +189     
- Misses       1425     1448      +23     
- Partials       91       96       +5
Flag Coverage Δ
#javascript 71.09% <88.3%> (+0.67%) ⬆️
#python 78.8% <88.3%> (+0.41%) ⬆️
Impacted Files Coverage Δ
src/smif/data_layer/abstract_data_store.py 100% <100%> (ø) ⬆️
src/smif/data_layer/abstract_metadata_store.py 100% <100%> (ø) ⬆️
src/smif/data_layer/file/file_data_store.py 87.07% <100%> (+0.26%) ⬆️
src/smif/metadata/timestep.py 100% <100%> (ø) ⬆️
src/smif/data_layer/store.py 91.29% <82.24%> (-4.48%) ⬇️
src/smif/decision/decision.py 93.22% <89.51%> (-0.12%) ⬇️
src/smif/data_layer/results.py 91.52% <91.52%> (ø)
src/smif/data_layer/data_handle.py 82.8% <92.85%> (-0.68%) ⬇️
src/smif/data_layer/data_array.py 86.89% <0%> (+0.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25951d...5c1d790. Read the comment docs.

@tomalrussell tomalrussell marked this pull request as ready for review May 7, 2019 15:36
@tomalrussell tomalrussell merged commit bd967e7 into master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants