Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port POI patches #1434

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Port POI patches #1434

wants to merge 4 commits into from

Conversation

antony-liu
Copy link
Collaborator

@antony-liu antony-liu commented Oct 20, 2024 •
edited
Loading

POI patches:

  • bug 60260: parse unicode sheet names
  • bug 60601: unset hyperlinks after removing them individually from the DOM
  • bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks
  • bug 60601: hyperlinks have to be removed one by one to avoid other errors
  • bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz
  • refactor duplicated code in TestXSSFSheet#setColumnGroupCollapsed; remove unnecessary int to short casts

@antony-liu
poi: bug 60260: parse unicode sheet names
6ec3c11
@antony-liu
poi: bug 60601: unset hyperlinks after removing them individually fro…
81ea74e 
…m the DOM

bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks
bug 60601: hyperlinks have to be removed one by one to avoid other errors
bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz
@antony-liu
poi: refactor duplicated code in TestXSSFSheet#setColumnGroupCollapse…
1ade0af 
…d; remove unnecessary int to short casts
@antony-liu
Merge branch 'master' into poi/v3.16-patch9
2b2a73c
@tonyqus tonyqus changed the title Port POI pathces Port POI patches Oct 20, 2024
@tonyqus tonyqus added this to the NPOI 2.7.2 milestone Oct 21, 2024
@tonyqus tonyqus added the bug label Oct 21, 2024
Bykiev
Bykiev approved these changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bykiev Bykiev Bykiev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
NPOI 2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@antony-liu @Bykiev @tonyqus