Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Implement gosec in github actions. #521

Merged
merged 2 commits into from
Oct 23, 2023
Merged

ci: Implement gosec in github actions. #521

merged 2 commits into from
Oct 23, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Oct 18, 2023

No description provided.

@tjholm tjholm requested a review from jyecusch as a code owner October 18, 2023 02:13
davemooreuws
davemooreuws requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test suite isn't running in /nitric/cloud/common

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
core/pkg/adapters/grpc/document_grpc.go 60.43% <100.00%> (+0.21%) ⬆️
cloud/aws/runtime/events/sns.go 62.01% <0.00%> (ø)
cloud/azure/runtime/queue/azqueue.go 56.35% <66.66%> (+0.24%) ⬆️
cloud/aws/runtime/queue/sqs.go 55.34% <50.00%> (-0.06%) ⬇️
cloud/gcp/runtime/queue/pubsub.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@tjholm tjholm merged commit 73dc03c into develop Oct 23, 2023
5 checks passed
@tjholm tjholm deleted the gosec branch October 23, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemooreuws davemooreuws davemooreuws approved these changes

@jyecusch jyecusch jyecusch approved these changes

Assignees

@jyecusch jyecusch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjholm @jyecusch @davemooreuws