feat: automatic query param decoding (#183)

Fixes #184
nitrictech · May 16, 2023 · 47639ed · 47639ed
2 parents 95e7327 + 314d422
commit 47639ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/faas/v0/context.test.ts b/src/faas/v0/context.test.ts
@@ -39,6 +39,9 @@ describe('NitricTrigger.fromGrpcTriggerRequest', () => {
       const testQuery = new QueryValue();
       testQuery.addValue('test');
       ctx.getQueryParamsMap().set('test', testQuery);
+      const testEncodedQuery = new QueryValue();
+      testEncodedQuery.addValue(encodeURIComponent('/path/here'));
+      ctx.getQueryParamsMap().set('test-encoded', testEncodedQuery);
       const request = new TriggerRequest();
       request.setData('Hello World');
       request.setHttp(ctx);
@@ -69,6 +72,7 @@ describe('NitricTrigger.fromGrpcTriggerRequest', () => {
 
     it('should have the provided query params', () => {
       expect(trigger.http.req.query['test']).toBe('test');
+      expect(trigger.http.req.query['test-encoded']).toBe('/path/here');
     });
 
     it('should allow json response', () => {

diff --git a/src/faas/v0/context.ts b/src/faas/v0/context.ts
@@ -302,7 +302,10 @@ export class HttpContext extends TriggerContext<HttpRequest, HttpResponse> {
     ).reduce(
       (acc, [key, [val]]) => ({
         ...acc,
-        [key]: val.length === 1 ? val[0] : val,
+        [key]:
+          val.length === 1
+            ? decodeURIComponent(val[0])
+            : val.map((v) => decodeURIComponent(v)),
       }),
       {}
     );
@@ -326,7 +329,7 @@ export class HttpContext extends TriggerContext<HttpRequest, HttpResponse> {
       .reduce(
         (acc, [key, val]) => ({
           ...acc,
-          [key]: val,
+          [key]: decodeURIComponent(val),
         }),
         {}
       );