fix: Don't overwrite blobRequest event fields (#225)

Also fix missing bucket reference for bucket references with permissions when adding notifications.
nitrictech · Apr 11, 2024 · 62d62c7 · 62d62c7
1 parent e8243c6
commit 62d62c7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/api/storage/v1/storage.ts b/src/api/storage/v1/storage.ts
@@ -120,7 +120,7 @@ export class Bucket {
       notificationPrefixFilter,
       ...middleware
     );
-    return notification['start']();
+    return notification['start'](this);
   }
 }
 

diff --git a/src/resources/bucket.ts b/src/resources/bucket.ts
@@ -33,7 +33,6 @@ import {
   ClientMessage,
   RegistrationRequest,
   ServerMessage,
-  BlobEvent,
   BlobEventResponse,
 } from '@nitric/proto/storage/v1/storage_pb';
 import { StorageListenerClient } from '@nitric/proto/storage/v1/storage_grpc_pb';
@@ -138,12 +137,6 @@ export class BucketNotification {
           responseMessage.setId(message.getId());
 
           try {
-            blobEventRequest.setBucketName(this.options.bucket);
-            const blobEvent = new BlobEvent();
-            blobEvent.setKey(this.options.notificationPrefixFilter);
-            blobEvent.setType(this.options.notificationType);
-            blobEventRequest.setBlobEvent(blobEvent);
-
             if (bucket) {
               const ctx = BlobEventContext.fromRequest(
                 blobEventRequest,