fix: Ensure at least one permission when calling for on secure resour…

…ces. (#209)
nitrictech · Nov 13, 2023 · 94707b6 · 94707b6
2 parents 4d87da8 + b68b855
commit 94707b6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/resources/bucket.ts b/src/resources/bucket.ts
@@ -211,7 +211,7 @@ export class BucketResource extends SecureResource<BucketPermission> {
    * @param perms the required permission set
    * @returns a usable bucket reference
    */
-  public for(...perms: BucketPermission[]): Bucket {
+  public for(perm: BucketPermission, ...perms: BucketPermission[]): Bucket {
     this.registerPolicy(...perms);
 
     return storage().bucket(this.name);

diff --git a/src/resources/collection.ts b/src/resources/collection.ts
@@ -107,7 +107,7 @@ export class CollectionResource<
    * @param perms the required permission set
    * @returns a usable collection reference
    */
-  public for(...perms: CollectionPermission[]) {
+  public for(perm: CollectionPermission, ...perms: CollectionPermission[]) {
     this.registerPolicy(...perms);
 
     return documents().collection<T>(this.name);

diff --git a/src/resources/queue.ts b/src/resources/queue.ts
@@ -92,7 +92,7 @@ export class QueueResource<
    * @param perms the access that the currently scoped function is requesting to this resource.
    * @returns a useable queue.
    */
-  public for(...perms: QueuePermission[]): Queue<T> {
+  public for(perm: QueuePermission, ...perms: QueuePermission[]): Queue<T> {
     this.registerPolicy(...perms);
 
     return queues().queue(this.name);

diff --git a/src/resources/secret.ts b/src/resources/secret.ts
@@ -79,7 +79,7 @@ export class SecretResource extends SecureResource<SecretPermission> {
     throw new Error('details unimplemented for secret');
   }
 
-  public for(...perms: SecretPermission[]): Secret {
+  public for(perm: SecretPermission, ...perms: SecretPermission[]): Secret {
     this.registerPolicy(...perms);
 
     return secrets().secret(this.name);

diff --git a/src/resources/topic.ts b/src/resources/topic.ts
@@ -136,7 +136,7 @@ export class TopicResource<
    * @param perms the required permission set
    * @returns a usable topic reference
    */
-  public for(...perms: TopicPermission[]): Topic<T> {
+  public for(perm: TopicPermission, ...perms: TopicPermission[]): Topic<T> {
     this.registerPolicy(...perms);
     return events().topic(this.name);
   }