Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add generic typing for queues #174

Merged
merged 3 commits into from
May 1, 2023
Merged

feat: Add generic typing for queues #174

merged 3 commits into from
May 1, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (0664462) 85.90% compared to head (2d19e24) 86.01%.

❗ Current head 2d19e24 differs from pull request most recent head ae7c395. Consider uploading reports for the commit ae7c395 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    85.90%   86.01%   +0.11%     
===========================================
  Files           83       84       +1     
  Lines         1518     1530      +12     
  Branches       207      209       +2     
===========================================
+ Hits          1304     1316      +12     
+ Misses         214      208       -6     
- Partials         0        6       +6     
Impacted Files Coverage Δ
src/faas/v0/handler.ts 100.00% <ø> (ø)
src/resources/topic.ts 86.95% <ø> (ø)
src/api/events/v0/events.ts 98.30% <100.00%> (+0.02%) ⬆️
src/api/queues/v0/queues.ts 96.29% <100.00%> (-0.05%) ⬇️
src/resources/queue.ts 78.94% <100.00%> (ø)
src/types.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/types.ts Outdated Show resolved Hide resolved
@tjholm tjholm merged commit 096041b into develop May 1, 2023
@HomelessDinosaur HomelessDinosaur deleted the queue-typing branch May 1, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants