Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bucket notification #178

Merged
merged 13 commits into from
May 9, 2023

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 54.28% and project coverage change: -2.83 ⚠️

Comparison is base (0664462) 85.90% compared to head (a1eeb06) 83.07%.

❗ Current head a1eeb06 differs from pull request most recent head fcfec95. Consider uploading reports for the commit fcfec95 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #178      +/-   ##
===========================================
- Coverage    85.90%   83.07%   -2.83%     
===========================================
  Files           83       84       +1     
  Lines         1518     1625     +107     
  Branches       207      231      +24     
===========================================
+ Hits          1304     1350      +46     
- Misses         214      268      +54     
- Partials         0        7       +7     
Impacted Files Coverage Δ
src/api/storage/v0/storage.ts 96.87% <ø> (ø)
src/faas/v0/handler.ts 100.00% <ø> (ø)
src/resources/api.ts 83.33% <ø> (ø)
src/resources/topic.ts 86.95% <ø> (ø)
src/faas/v0/context.ts 60.22% <16.00%> (-16.11%) ⬇️
src/faas/v0/start.ts 31.78% <25.92%> (-1.82%) ⬇️
src/resources/bucket.ts 80.95% <91.66%> (+6.59%) ⬆️
src/api/events/v0/events.ts 98.30% <100.00%> (+0.02%) ⬆️
src/api/queues/v0/queues.ts 96.29% <100.00%> (-0.05%) ⬇️
src/resources/queue.ts 78.94% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

package.json Outdated Show resolved Hide resolved
@tjholm tjholm dismissed davemooreuws’s stale review May 9, 2023 03:24

change addressed

@tjholm tjholm merged commit 35eee72 into nitrictech:develop May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants