Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing resource configs for declared resources. #216

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix missing resource configs for declared resources. #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/resources/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
ResourceDeclareResponse,
ResourceType,
ResourceTypeMap,
BucketResource as NitricBucketResource,
} from '@nitric/proto/resources/v1/resources_pb';
import resourceClient from './client';
import { storage, Bucket } from '../api/storage';
Expand Down Expand Up @@ -228,6 +229,7 @@ export class BucketResource extends SecureResource<BucketPermission> {
resource.setType(ResourceType.BUCKET);

req.setId(resource);
req.setBucket(new NitricBucketResource());

return new Promise<ResourceIdentifier>((resolve, reject) => {
resourceClient.declare(req, (error, _: ResourceDeclareResponse) => {
Expand Down
3 changes: 3 additions & 0 deletions src/resources/keyvalue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
Action,
ResourceTypeMap,
ActionMap,
KeyValueStoreResource as NitricKeyValueStoreResource,
} from '@nitric/proto/resources/v1/resources_pb';
import { keyvalue, ValueStructure } from '../api/keyvalue';
import resourceClient from './client';
Expand Down Expand Up @@ -48,6 +49,8 @@ export class KeyValueStoreResource<
resource.setType(ResourceType.KEYVALUESTORE);
req.setId(resource);

req.setKeyValueStore(new NitricKeyValueStoreResource());

return new Promise<ResourceIdentifier>((resolve, reject) => {
resourceClient.declare(
req,
Expand Down
2 changes: 2 additions & 0 deletions src/resources/queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
ResourceDeclareResponse,
ResourceType,
Action,
QueueResource as NitricQueueResource,
ResourceTypeMap,
} from '@nitric/proto/resources/v1/resources_pb';
import resourceClient from './client';
Expand All @@ -43,6 +44,7 @@ export class QueueResource<
resource.setName(this.name);
resource.setType(ResourceType.QUEUE);
req.setId(resource);
req.setQueue(new NitricQueueResource())

return new Promise<ResourceIdentifier>((resolve, reject) => {
resourceClient.declare(req, (error) => {
Expand Down
3 changes: 3 additions & 0 deletions src/resources/secret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
ResourceDeclareRequest,
ResourceDeclareResponse,
ResourceTypeMap,
SecretResource as NitricSecretResource,
} from '@nitric/proto/resources/v1/resources_pb';
import resourceClient from './client';
import { secrets, Secret } from '../api/secrets';
Expand All @@ -38,7 +39,9 @@ export class SecretResource extends SecureResource<SecretPermission> {
resource.setName(this.name);
resource.setType(ResourceType.SECRET);

req.setSecret(new NitricSecretResource());
req.setId(resource);


return new Promise<ResourceIdentifier>((resolve, reject) => {
resourceClient.declare(
Expand Down
2 changes: 2 additions & 0 deletions src/resources/topic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
ResourceType,
Action,
ResourceTypeMap,
TopicResource as NitricTopicResource,
} from '@nitric/proto/resources/v1/resources_pb';
import {
ActionsList,
Expand Down Expand Up @@ -140,6 +141,7 @@ export class TopicResource<
resource.setName(this.name);
resource.setType(ResourceType.TOPIC);
req.setId(resource);
req.setTopic(new NitricTopicResource());

return new Promise<ResourceIdentifier>((resolve, reject) => {
resourceClient.declare(
Expand Down
Loading