-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert dependency version regression, fix dependabot config #1104
base: main
Are you sure you want to change the base?
Conversation
Dependabot changed `error-prone` library to 2.36.0 again in nitrite#1089, re-breaking the fix that was included in nitrite#1083. This reverts commit 6902df0.
WalkthroughThe pull request introduces modifications to the Dependabot configuration in Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (14)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Now I'm confused as to how it built successfully on CI. Maybe there's just something strange about my local dev setup? The release notes for Error Prone 23.1.0 seem pretty clear that it won't build with JDK 11... |
Dependabot suggested to change
error-prone
library to 2.36.0 again in #1089, and it was accepted/merged, which re-breaks the fix that was included in #1083.In order to prevent future such regressions, I took it upon myself to configure
dependabot
to ignore certain packages. The documentation is thorough but lacks examples. I found this config in the wild via Github search and it made the usage clear enough.Then I did some additional research to understand how to make the update PRs less noisy via "groups". Here are a couple of examples of dependabot
groups
usage in projects that I would expect know what they're doing: 1, 2, 3Summary by CodeRabbit
Dependency Management
Dependency Version