Don't use options object for listening on unix socket #2877
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is so nitro works on a passenger server with autoinstall turned on
https://www.phusionpassenger.com/library/indepth/nodejs/reverse_port_binding.html
The gist is that if we have multiple server.listen on passenger, we need to disable autoinstall and instead call
server.listen('passenger', ...)
It is very important that the parameter is a string, it cannot be passed as an object like
{path: 'passenger'}
or{port: 'passenger'}
, otherwise passenger doesn't pick up on it and instead the server will be registered on a unix socketpassenger
in the cwd