-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul learning section and add a bunch of things #172
Conversation
This is really good and covers a lot. Should probably be most people's introduction to Nix. Not the current number one there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this below the "How to Learn" entry to maintain alphabetical ordering. Otherwise looks good
That How to Learn Nix series of articles is pretty outdated. Not sure if that makes sense. Let me make a bigger change with in what direction I'm thinking of here. |
Here:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/good-non-official-nix-resources/28400/3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay -- again, looking to maintain alphabetical ordering.
Breaking out sections doesn't make sense as well when there are only one or two items to even put in the section.
Also, that's 4 new entries. I'm not against reviewing them, but you've made this difficult by putting them all in the same PR, alongside a bunch of formatting and ordering changes, instead of letting each one stand on its own. Nor does it seem appropriate to have multiple copies of the same resource (nix.dev
) in this list.
Please either present individual suggestions for the items, or consider just reorganization within a single PR, like I did in #158
I don't understand. Wouldn't this be the reorganization within a single PR?
I think more items would be found for the other sections but I think it makes sense to break these out because they're distinctly different things. A person interested in nixpkgs does not necessarily have to be interested in NixOS. Also we can maintain alphabetical order but it would mean highly outdated things coming before newer resources. But OK. Let me know if this can go as a single PR and otherwise I'll break this up in single suggestions. |
Yes, this is within a single PR. It isn't just reorganization though, it's a bunch of additions and moves as well. If these older items are outright incorrect now, we can move them to the |
I'd prefer to never see anything about NixOS but in most places it is the dominant thing that most conversations and questions are about. |
OK. I'm closing this and I made a bunch of PRs with single additions in each all of which should still be alphabetical. |
This is really good and covers a lot. Should probably be most people's introduction to Nix. Not the current number one there.