type/lvm_vg: fix luks on lvm with raid #356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch fixes opening a luks device on top of lvm in stage-1. previously, the preLVM flag would be set for luks devices even if they were part of a lvm logical volume, obviously requiring to be opened after lvm creating the logical volume's device. Co-authored-by: Emily <[email protected]>
this patch fixes mdraid not being enabled when using lvm's raid types, causing setup to fail as lvm relies on mdraid internally. Co-authored-by: Emily <[email protected]>
this fixes creating a logical volume of type raid0. Co-authored-by: Emily <[email protected]>
networkException
force-pushed
the
luks-on-lvm-fixes
branch
from
705c60c
to
636fed9
Compare
|
Are you still working on this? |
|
I wanted to add tests but there are a bunch of open questions that require design decisions: https://matrix.to/#/!oNSIfazDqEcwhcOjSL:matrix.org/$VXv0SO7-Lppg_qn2baQGpeYl1ppdY9s77I8dgJ-FuNA?via=chat.upi.li&via=matrix.org&via=lassul.us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request fixes creating and mounting (in stage-1) a luks device on a lvm logical volume raid