-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/nixos: add cgroups and exporter #1466
base: master
Are you sure you want to change the base?
Conversation
flake.nix
Outdated
@@ -16,6 +16,8 @@ | |||
buildbot-nix.inputs.nixpkgs.follows = "nixpkgs"; | |||
buildbot-nix.inputs.treefmt-nix.follows = "treefmt-nix"; | |||
buildbot-nix.url = "github:qowoz/buildbot-nix/more-skipped-build-workers"; | |||
cgroup-exporter.inputs.nixpkgs.follows = "nixpkgs"; | |||
cgroup-exporter.url = "github:arianvp/cgroup-exporter"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to send a PR upstream for aarch64-linux support.
flake.nix
Outdated
@@ -16,6 +16,8 @@ | |||
buildbot-nix.inputs.nixpkgs.follows = "nixpkgs"; | |||
buildbot-nix.inputs.treefmt-nix.follows = "treefmt-nix"; | |||
buildbot-nix.url = "github:qowoz/buildbot-nix/more-skipped-build-workers"; | |||
cgroup-exporter.inputs.nixpkgs.follows = "nixpkgs"; | |||
cgroup-exporter.url = "github:arianvp/cgroup-exporter"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference to this plugin? https://github.com/influxdata/telegraf/tree/master/plugins/inputs/cgroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I went with the cgroup-exporter
suggestion without checking if telegraf supported it.
Looks like the exporter collects almost everything and doesn't currently support any config, telegraf doesn't collect anything by default, requires config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to collect everything? We mainly do alert monitoring rather than looking at performance metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the plugin and some metrics had permission issues (telegraf user?) or were broken, exporter seems to work okay (or least doesn't seem to be missing anything notable).
Probably don't want to collect everything but might be easier to start with the exporter and try switching to the plugin later once we have a better idea of what we do want to collect rather than needing to configure it from the start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mainly do alert monitoring rather than looking at performance metrics.
Maybe I should bring back the grafana dashboard? I removed it as no one was using it but maybe it would more useful now? IIRC people on matrix were talking about checking the load on the build boxes, dashboard might be a bit better than people running top.
f3527c2
to
ec18abd
Compare
ea26cdd
to
70b5371
Compare
No description provided.