feat: Add package list metadata to Terraform build output via nvd #460
Conversation
oneingan
changed the title
| @@ -39,5 +39,20 @@ else | |||
| # inject `special_args` into nixos config's `specialArgs` | |||
| # shellcheck disable=SC2086 | |||
| out=$(nix build --no-link --json ${options} --expr "${nix_expr}" "${config_attribute}") | |||
| output_path=$(echo "$out" | jq -r '.[].outputs.out') | |||
| packages_json=$(nvd list --selected --root "$output_path" | awk ' | |||
There was a problem hiding this comment.
Maybe add some conditional if nvd is not present?
if command -v nvd; then
fi
There was a problem hiding this comment.
Currently we don't enable pipefail but I think we should
| @@ -1,6 +1,7 @@ | |||
| resource "null_resource" "nixos-rebuild" { | |||
| triggers = { | |||
| store_path = var.nixos_system | |||
| packages_list = var.nixos_system_packages | |||
There was a problem hiding this comment.
I am not quite getting, why we need this trigger? Is the store_path not enough?
There was a problem hiding this comment.
If I'm not mistaken, you need it for package_list diff to be displayed during the plan, though I could be wrong.
There was a problem hiding this comment.
I see. Actually the terraform option description is a bit misleading in this case, which was also the initial source of my confusion. Could you change that and also add to nixos-rebuild.md how to wire things up i.e. use nix-build output and feed it into the nixos-rebuild module?
Changes
This PR enhances the Nix build script to:
nvd liston the derivation output to collect installed packages.out(build path) andpackages(serialized JSON array).Example Output:
{ "out": "/nix/store/...-nixos-system", "packages": "[{\"name\":\"acl\",\"versions\":\"2.3.2 x2\"},...]" }Notes
nvdinstalled, but if not returns an empty list