Skip to content

Commit

Permalink
Merge pull request #399 from qowoz/review-timeout
Browse files Browse the repository at this point in the history
increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 100
  • Loading branch information
zowoq authored Apr 28, 2024
2 parents 0572aa4 + 5b65371 commit fc6a441
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion doc/nixpkgs-maintainer-faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Updates can be disabled by adding a comment to the package:

We maintain a [Skiplist](https://github.com/ryantm/nixpkgs-update/blob/main/src/Skiplist.hs) of different things not to update. It is possible your package is triggering one of the skip criteria.

Python updates are skipped if they cause more than 25 rebuilds.
Python updates are skipped if they cause more than 100 rebuilds.

### Existing Open or Draft PR

Expand Down
2 changes: 1 addition & 1 deletion src/NixpkgsReview.hs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ run ::
Text ->
Sem r Text
run cache commit =
let timeout = "45m" :: Text
let timeout = "120m" :: Text
in do
-- TODO: probably just skip running nixpkgs-review if the directory
-- already exists
Expand Down
2 changes: 1 addition & 1 deletion src/Skiplist.hs
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,4 @@ python numPackageRebuilds derivationContents =
(not isPython || numPackageRebuilds <= maxPackageRebuild)
where
isPython = "buildPythonPackage" `T.isInfixOf` derivationContents
maxPackageRebuild = 25
maxPackageRebuild = 100

0 comments on commit fc6a441

Please sign in to comment.