colorschemes/base16: add settings + refactor to fix #1675 #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
base16
branch
2 times, most recently
from
cf2add6 to
2782fa7
Compare
MattSturgeon
commented
Jun 12, 2024
MattSturgeon
commented
Jun 12, 2024
MattSturgeon
changed the title
Turns out the This is good, because we don't need any new warnings or changed behaviour! |
MattSturgeon
force-pushed
the
base16
branch
2 times, most recently
from
802d21c to
c9dd15b
Compare
MattSturgeon
commented
Jun 12, 2024
There was a problem hiding this comment.
theme-list is probably still too long for the docs. Feel free to suggest more removals.
MattSturgeon
commented
Jun 12, 2024
MattSturgeon
commented
Jun 12, 2024
MattSturgeon
force-pushed
the
base16
branch
5 times, most recently
from
5cde820 to
40ce354
Compare
GaetanLepage
approved these changes
Jul 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Added support for the plugin's "advanced" config settings. Removed the enum restriction and prefix concatenation, allowing anything to be passed through, including raw lua: fixes nix-community#1675 The theme list is now much shorter and is included directly in the option description. Some general cleanup, in particular to `extraConfig` and `customColorschemeType`.
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c0ea106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the enum restriction on the
colorschemeoption, allowing anything to be passed through, including raw lua. This fixes #1675Settings
Added support for the plugin's "advanced" config settings and simplified the
extraConfigimplementation.As some of their API is undocumented, I've opened RRethy/base16-nvim#102. Should we wait for acknowledgement?
Enum
Previously, we listed all builtin base16 colorschemes in theme-list.nix, however this means we have to maintain that list, ensuring it tracks any upstream changes.
Also worth noting that upstream don't always have their docs up to date. I've opened a PR to hopefully address this: RRethy/base16-nvim#103.
Having a ~240 value enum type wasn't particularly readable though, anyway...
Current documentation (screenshot)
Refactor
I've cleaned up some of the implementation. In particular, I found a more readable way to define
customColorschemeTypeusingstringToCharactersandgenAttrsmapAttrson the example attrs.Rename
EDIT: this section is irrelevant now that we know the lua API (
setup) doesn't use thebase16-prefix.Details
I toyed with renaming the option to
colorsto match upstream's internal name, and to allow automatically apply the prefix to be done only when the old name was used.In the end I decided the rename wasn't worth it. Let me know if you disagree.