-
-
Notifications
You must be signed in to change notification settings - Fork 283
bemenu: add testbed #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bemenu: add testbed #1769
Conversation
| }; | ||
|
|
||
| home-manager.sharedModules = lib.singleton { | ||
| programs.bemenu.enable = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theming doesn't seem to be applying for some reason
We need to trigger the code path that enables home.sessionVariables to be generated:
home.sessionVariables = lib.mkIf (cfg.settings != { }) { BEMENU_OPTS = lib.cli.toGNUCommandLineShell { } cfg.settings; };-- github:nix-community/home-manager,
/modules/programs/bemenu.nix
I believe the following should fix it:
| programs.bemenu.enable = true; | |
| programs = { | |
| bash.enable = true; | |
| bemenu.enable = true; | |
| }; |
The same is done in:
stylix/modules/fzf/testbeds/fzf.nix
Lines 9 to 12 in fc24382
| programs = { | |
| bash.enable = true; | |
| fzf.enable = true; | |
| }; |
It might be better to generally programs.bash.enable = true; in all testbeds to avoid relying on the implementation detail of relying on environment variables. I will try to open a PR for this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm adding bash.enable doesn't seem to fix the problem and echo $BEMENU_OPTS prints nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm adding
bash.enabledoesn't seem to fix the problem andecho $BEMENU_OPTSprints nothing.
Maybe cfg.settings is empty in the testbed for some reason:
home.sessionVariables = lib.mkIf (cfg.settings != { }) { BEMENU_OPTS = lib.cli.toGNUCommandLineShell { } cfg.settings; };-- github:nix-community/home-manager,
/modules/programs/bemenu.nix
Maybe the groups are not ensured to be enabled:
Lines 29 to 31 in cf71ad5
{ cfg, fonts }: { programs.bemenu.settings = { Lines 40 to 46 in cf71ad5
{ colors, opacity, cfg, }: { programs.bemenu.settings =
In that case, this would be a general problem with all testbeds.
It might be better to generally
programs.bash.enable = true;in all testbeds to avoid relying on the implementation detail of relying on environment variables.
This should be resolved by #1803.
theming doesn't seem to be applying for some reason
Things done
Notify maintainers
@Noodlez1232