-
-
Notifications
You must be signed in to change notification settings - Fork 283
qt: added extraQtctConfig option #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added extraQtctConfig option; qtct config is generated with pkgs.formats.ini now
|
didn't tested yet, if you did please ping me |
0xda157
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer upstreaming an option into home-manager, similar to #481
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't tested yet, if you did please ping me
If one of our testbeds includes a Qt application, you can test this PR that way. At least, the following testbeds are failing:
[...] ERROR:nix_fast_build:EVAL: 275 successes, 50 failures [...] ERROR:nix_fast_build:Failed attributes: .#checks.aarch64-linux.testbed:ashell:cursorless .#checks.aarch64-linux.testbed:ashell:light .#checks.aarch64-linux.testbed:ashell:dark .#checks.aarch64-linux.testbed:ashell:imageless .#checks.aarch64-linux.testbed:bat:cursorless .#checks.aarch64-linux.testbed:bat:dark .#checks.aarch64-linux.testbed:bat:imageless .#checks.aarch64-linux.testbed:ashell:schemeless .#checks.aarch64-linux.testbed:bat:light .#checks.aarch64-linux.testbed:bat:schemeless .#checks.aarch64-linux.testbed:bspwm:cursorless .#checks.aarch64-linux.testbed:bspwm:dark .#checks.aarch64-linux.testbed:bspwm:imageless .#checks.aarch64-linux.testbed:bspwm:light .#checks.aarch64-linux.testbed:bspwm:schemeless .#checks.aarch64-linux.testbed:dunst:cursorless .#checks.aarch64-linux.testbed:dunst:dark .#checks.aarch64-linux.testbed:dunst:imageless .#checks.aarch64-linux.testbed:dunst:light .#checks.aarch64-linux.testbed:dunst:schemeless .#checks.aarch64-linux.testbed:fnott:dark .#checks.aarch64-linux.testbed:fnott:cursorless .#checks.aarch64-linux.testbed:fnott:imageless .#checks.aarch64-linux.testbed:fnott:light .#checks.aarch64-linux.testbed:fnott:schemeless .#checks.aarch64-linux.testbed:fuzzel:cursorless .#checks.aarch64-linux.testbed:fuzzel:dark .#checks.aarch64-linux.testbed:fuzzel:schemeless .#checks.aarch64-linux.testbed:fuzzel:light .#checks.aarch64-linux.testbed:fuzzel:imageless .#checks.aarch64-linux.testbed:hyprland:cursorless .#checks.aarch64-linux.testbed:hyprland:dark .#checks.aarch64-linux.testbed:hyprland:imageless .#checks.aarch64-linux.testbed:hyprland:schemeless .#checks.aarch64-linux.testbed:hyprland:light .#checks.aarch64-linux.testbed:mako:dark .#checks.aarch64-linux.testbed:mako:cursorless .#checks.aarch64-linux.testbed:mako:imageless .#checks.aarch64-linux.testbed:mako:light .#checks.aarch64-linux.testbed:mako:schemeless .#checks.aarch64-linux.testbed:waybar:cursorless .#checks.aarch64-linux.testbed:waybar:dark .#checks.aarch64-linux.testbed:waybar:light .#checks.aarch64-linux.testbed:wayprompt:cursorless .#checks.aarch64-linux.testbed:waybar:schemeless .#checks.aarch64-linux.testbed:waybar:imageless .#checks.aarch64-linux.testbed:wayprompt:dark .#checks.aarch64-linux.testbed:wayprompt:imageless .#checks.aarch64-linux.testbed:wayprompt:light .#checks.aarch64-linux.testbed:wayprompt:schemeless
I would prefer upstreaming an option into home-manager, similar to #481
Agreed. Although, that is technically out of the scope of this PR.
qtct configuration files are generated with pkgs.formats.ini now
What is the urgency of this change? Does Stylix fail to evaluate without this patch? Ideally, an option is upstreamed to Home Manager, so others also benefit from this.
qtct configuration files are generated with pkgs.formats.ini now