DankMaterialShell: init target #1932

khas-amir · 2025-10-04T22:53:54Z

#1924

I certify that I have the right to submit this contribution under the MIT license
Commit messages adhere to Stylix commit conventions
Theming changes adhere to the Stylix style guide
Changes have been tested locally
Changes have been tested in testbeds
Each commit in this PR is suitable for backport to the current stable branch

This reverts commit 5ab8f90.

trueNAHO

Changes have been tested in testbeds

Would be great to have a testbed for this.

trueNAHO · 2025-10-08T21:22:22Z

modules/dankMaterialShell/hm.nix

+    (
+      { colors }:
+      let
+        colorTheme = {


Why are the dark and light themes so different?

trueNAHO · 2025-10-08T21:22:40Z

modules/dankMaterialShell/hm.nix

+      in
+      {
+        home.file.".config/DankMaterialShell/stylix-colors.json".text =
+          builtins.toJSON colorTheme;


Might be better to inline this single-use variable.

trueNAHO · 2025-10-08T21:23:10Z

modules/dankMaterialShell/meta.nix

+  name = "dankMaterialShell";
+  homepage = "https://github.com/AvengeMedia/DankMaterialShell";
+  maintainers = [ lib.maintainers.khas-amir ];
+  description = ''In the settings, click Theme & Colors, then Custom, and select the path to the Stylix-generated color scheme ` ~/.config/DankMaterialShell/stylix-colors.json`'';


This should be properly wrapped:

Suggested change

description = ''In the settings, click Theme & Colors, then Custom, and select the path to the Stylix-generated color scheme ` ~/.config/DankMaterialShell/stylix-colors.json`'';

description = ''

In the settings, click Theme & Colors, then Custom, and select the path to

the Stylix-generated color scheme

`~/.config/DankMaterialShell/stylix-colors.json`.

'';

trueNAHO · 2025-10-08T21:29:09Z

modules/dankMaterialShell/meta.nix

+  name = "dankMaterialShell";
+  homepage = "https://github.com/AvengeMedia/DankMaterialShell";
+  maintainers = [ lib.maintainers.khas-amir ];
+  description = ''In the settings, click Theme & Colors, then Custom, and select the path to the Stylix-generated color scheme ` ~/.config/DankMaterialShell/stylix-colors.json`'';


What about automatically applying this? If this actually requires imperatively overriding configuration files, then we can use a similar approach to #951 (comment).

there is a settings file that stylix could modify, but it's only read on the shell starting up. maybe it could kill and restart the shell when it applies the theme?

Since restarting applications is an implicitly expected requirement, we can remove the following description:

stylix/modules/dankMaterialShell/meta.nix

Line 6 in 8dd66a3

description = "Restart the panel to apply the theme";

trueNAHO · 2025-10-08T21:29:56Z

modules/dankMaterialShell/meta.nix

@@ -0,0 +1,7 @@
+{ lib, ... }:
+{
+  name = "dankMaterialShell";


Should it not be:

Suggested change

name = "dankMaterialShell";

name = "DankMaterialShell";

modules/dankMaterialShell/hm.nix

Co-authored-by: awwpotato <[email protected]>

khas-amir · 2025-10-28T10:30:16Z

I don't understand why the checks are failing.

trueNAHO

I don't understand why the checks are failing.

The locally working evaluations are failing in CI for some reason:

2025-11-04T14:39:20.6152550Z building '/nix/store/r3va1pk1gc1wnmn4ajr8f3vbqicxyx8r-dgop-0.1.7.drv'...
2025-11-04T14:39:20.8373284Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:20.8490390Z WARNING:nix_fast_build:build testbed:dankMaterialShell:light exited with 1
[...]
2025-11-04T14:39:46.9992225Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:47.0068660Z WARNING:nix_fast_build:build testbed:dankMaterialShell:dark exited with 1

-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

CI is using Nix 2.32.1 and does not seem to run out of space:

2025-11-04T15:01:53.3287684Z Filesystem      Size  Used Avail Use% Mounted on
2025-11-04T15:01:53.3288211Z /dev/root        72G   51G   22G  71% /
-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

Let's hope rerunning CI several times magically fixes the problem.

CC: @0xda157, @danth

@khas-amir, please address and potentially resolve previous change requests.

trueNAHO · 2025-11-04T13:59:38Z

modules/dankMaterialShell/meta.nix

+  name = "DankMaterialShell";
+  homepage = "https://github.com/AvengeMedia/DankMaterialShell";
+  maintainers = [ lib.maintainers.khas-amir ];
+  description = "Restart the panel to apply the theme";


Could you rephrase the description with the IMPORTANT admonition to match the current style:

$ rg --files-with-matches '> \[!IMPORTANT\]' doc/src/modules.md modules/blender/meta.nix modules/discord/meta.nix modules/firefox/meta.nix modules/i3/meta.nix modules/neovim/meta.nix modules/spicetify/meta.nix modules/sway/meta.nix modules/zen-browser/meta.nix

trueNAHO · 2025-11-04T14:04:25Z

modules/dankMaterialShell/meta.nix

+  name = "dankMaterialShell";
+  homepage = "https://github.com/AvengeMedia/DankMaterialShell";
+  maintainers = [ lib.maintainers.khas-amir ];
+  description = ''In the settings, click Theme & Colors, then Custom, and select the path to the Stylix-generated color scheme ` ~/.config/DankMaterialShell/stylix-colors.json`'';


Since restarting applications is an implicitly expected requirement, we can remove the following description:

stylix/modules/dankMaterialShell/meta.nix

Line 6 in 8dd66a3

description = "Restart the panel to apply the theme";

trueNAHO · 2025-11-04T14:11:49Z

modules/dankMaterialShell/hm.nix

+    in
+    {
+      home.file.${stylixThemePath}.text = builtins.toJSON colorTheme;
+      programs.dankMaterialShell.default.settings = {


Subjective nitpick:

Suggested change

programs.dankMaterialShell.default.settings = {

programs.dankMaterialShell.default.settings = {

modules/dankMaterialShell/hm.nix

flake/dev/flake.nix

trueNAHO · 2025-11-08T15:19:59Z

I don't understand why the checks are failing.

The locally working evaluations are failing in CI for some reason:

2025-11-04T14:39:20.6152550Z building '/nix/store/r3va1pk1gc1wnmn4ajr8f3vbqicxyx8r-dgop-0.1.7.drv'...
2025-11-04T14:39:20.8373284Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:20.8490390Z WARNING:nix_fast_build:build testbed:dankMaterialShell:light exited with 1
[...]
2025-11-04T14:39:46.9992225Z error: Nix daemon disconnected unexpectedly (maybe it crashed?)
2025-11-04T14:39:47.0068660Z WARNING:nix_fast_build:build testbed:dankMaterialShell:dark exited with 1

-- https://github.com/nix-community/stylix/actions/runs/18920823815/job/54477479189?pr=1932

Maybe rebasing this PR on top of #1961 once its CI passes, also resolves this CI failure.

0xda157 · 2025-11-18T19:42:57Z

pulling from master again should fix the ci

0xda157 · 2025-11-21T04:06:42Z

stylix/testbed/default.nix

                inputs.zen-browser.homeModules.default
              ];
+
+              dankMaterialShell.home-manager.sharedModules = [


consider sorting this attrset, so darkMaterialShell would be first (note we can't use keep-sorted here due to it not working properly with inherit)

DankMaterialShell: init target

02acd2d

stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Oct 4, 2025

DankMaterialShell: Set theme automatically

5ab8f90

khas-amir marked this pull request as draft October 5, 2025 17:09

Revert "DankMaterialShell: Set theme automatically"

81cb511

This reverts commit 5ab8f90.

khas-amir marked this pull request as ready for review October 8, 2025 17:45

khas-amir requested a review from trueNAHO October 8, 2025 17:46

trueNAHO requested changes Oct 8, 2025

View reviewed changes

khas-amir marked this pull request as draft October 20, 2025 21:37

khas-amir added 2 commits October 21, 2025 03:17

DankMaterialShell: Update

3e0d378

DankMaterialShell: add testbed

8bfccd2

stylix-automation bot added topic: testbed Testbed changes topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: stylix /stylix/ subsystem labels Oct 27, 2025

DankMaterialShell: fix

a29f1d8

0xda157 reviewed Oct 27, 2025

View reviewed changes

modules/dankMaterialShell/hm.nix Outdated Show resolved Hide resolved

khas-amir and others added 2 commits October 28, 2025 12:18

Update modules/dankMaterialShell/hm.nix

f766fe3

Co-authored-by: awwpotato <[email protected]>

DankMaterialShell: another fix

7a5592d

khas-amir marked this pull request as ready for review October 28, 2025 10:05

stylix-automation bot added the status: merge conflict Merge conflict label Oct 28, 2025

khas-amir added 2 commits October 28, 2025 23:18

Merge branch 'master' into feat/DankMaterialShell

db96e9c

DankMaterialShell: nit

8dd66a3

stylix-automation bot removed the status: merge conflict Merge conflict label Oct 30, 2025

khas-amir requested a review from trueNAHO October 31, 2025 22:25

trueNAHO requested changes Nov 4, 2025

View reviewed changes

DankMaterialShell: apply review suggestions

b037890

Merge branch 'master' into feat/DankMaterialShell

f32a26b

Merge branch 'master' into feat/DankMaterialShell

4adfd84

0xda157 reviewed Nov 21, 2025

View reviewed changes

DankMaterialShell: apply review suggestions

71dd191

khas-amir requested a review from 0xda157 November 22, 2025 12:28

	programs.dankMaterialShell.default.settings = {

	programs.dankMaterialShell.default.settings = {

Uh oh!

DankMaterialShell: init target #1932

Are you sure you want to change the base?

DankMaterialShell: init target #1932

Conversation

khas-amir commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trueNAHO left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trueNAHO Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

khas-amir commented Oct 28, 2025

Uh oh!

trueNAHO left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trueNAHO Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

trueNAHO commented Nov 8, 2025

Uh oh!

0xda157 commented Nov 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

khas-amir commented Oct 4, 2025 •

edited

Loading

trueNAHO Oct 8, 2025 •

edited

Loading

trueNAHO Nov 4, 2025 •

edited

Loading