-
Notifications
You must be signed in to change notification settings - Fork 0
Fix inconsistent date types in DateRangePicker and prevent consumer crashes #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
niyazmft
merged 3 commits into
main
from
fix-datepicker-mixed-types-8010108156156687080
Mar 19, 2026
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ec80834
Fix: ensure DateRangePicker consistently emits Date objects
google-labs-jules[bot] 35e1242
Fix: ensure DateRangePicker consistently emits Date objects and fix CI
google-labs-jules[bot] d9a7528
Merge branch 'main' into fix-datepicker-mixed-types-8010108156156687080
niyazmft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the comment here correctly identifies that the test stub for
DatePickeris emitting a string, the test then asserts this incorrect behavior. This test should enforce the component's contract, which is to emitDateobjects for all selection types.I recommend updating the
DatePickerstub to emitDateobjects (e.g., by usingnew Date($event.target.value)in the@inputhandler). Afterwards, this test can be updated to properly verify the emitted types and values, making it consistent with the new preset tests and preventing future regressions.