Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read all 16 bits in readPhyByte, not just upper 8 bits #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JerthG
Copy link

@JerthG JerthG commented Dec 17, 2020

readPhyByte would only read the upper 8 bits of the MIRD register. Now it should read all 16 bits.

@njh
Copy link
Owner

njh commented Dec 17, 2020

Thanks! Why was this useful for you?

@JerthG
Copy link
Author

JerthG commented Dec 17, 2020

I was fiddling around trying to use your library to create my own with only the functionality i needed.
And i wanted to read the PHID1 and PHID2 registers to make sure my SPI connection was working.

@JerthG
Copy link
Author

JerthG commented Dec 19, 2020

I see now that it broke isLinkUp, fixed that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants