Add plugin class diagram and README reference#229
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
rarexsec-analysis/docs/plugin_class_diagram.puml
Lines 20 to 34 in 1c16ba0
[P1] Align diagram with real plugin APIs
The new PlantUML diagram depicts IAnalysisPlugin exposing only onInitialisation, onEvent, and onFinalisation and both plugin managers having a single register() entry point. In the actual headers (libplug/IAnalysisPlugin.h and the manager classes) the required callbacks are onInitialisation, onPreSampleProcessing, onPostSampleProcessing, and onFinalisation, and managers expose loadPlugins() plus various notify*/run operations. Anyone implementing a plug‑in from this diagram will target non‑existent methods and miss mandatory ones, leading to build failures and misaligned documentation. Please update the diagram (and the README reference implicitly created) to mirror the real API surface.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
Testing
ctest --output-on-failure(no tests found)https://chatgpt.com/codex/tasks/task_e_68b87af2f73c832ea4501ca04dcc55b0