Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| explicit CutFlowPlotPlugin(const nlohmann::json &cfg) { | ||
| if (!cfg.contains("plots") || !cfg.at("plots").is_array()) | ||
| throw std::runtime_error("CutFlowPlotPlugin missing plots"); | ||
| throw std::onPlottime_error("CutFlowPlotPlugin missing plots"); | ||
| for (auto const &p : cfg.at("plots")) { |
There was a problem hiding this comment.
[P0] Replace accidental std::onPlottime_error rename
The global rename from run to onPlot also rewrote every std::runtime_error into std::onPlottime_error, which is not a standard exception type. Any translation unit that includes these constructors now fails to compile because std::onPlottime_error is undefined. Please revert these to std::runtime_error (or an application-specific type) in all affected plot plugin constructors.
Useful? React with 👍 / 👎.
1 participant
Summary
IPlotPluginhookruntoonPlotfor clearer behaviorPlotPluginManagerand call sites to usenotifyPlotTesting
bash .build.sh(fails: Could not find a package configuration file provided by "ROOT")https://chatgpt.com/codex/tasks/task_e_68bcc5771280832e85b4842cf6ca6613