Fixes taboo topic checking without session username. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, just noticed that by my mistake this commit includes also changes for Python 3.4.3 backward compatibility. |
|
Thank you for your commit. Indeed, it fixes the bug that prevents anonymous sessions. When will the commit be merged into master? |
|
+1 |
|
CI is failing, please fix it before merging. |
smurfix
added a commit
to smurfix/hbmqtt
that referenced
this pull request
Apr 14, 2019
15 tasks
FlorianLudwig
added a commit
to Yakifo/amqtt
that referenced
this pull request
Mar 9, 2021
FlorianLudwig
added a commit
to Yakifo/amqtt
that referenced
this pull request
Mar 10, 2021
pazzarpj
pushed a commit
to pazzarpj/amqtt
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though I don't completely understand the (undocumented) plugin system, I believe the topic-checking in the topic-taboo plugin is not implemented correctly and does not allow any topic subscriptions for anonymous sessions (without username).
This PR fixes at least this, and I don't dare to go further, but issues #145 and #129 are IMO spot on and basically prevent even the basic usage of hbmqtt broker as described in the current documentation.