Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to the newly published @types/httptoolkit__esm #82

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

nktnet1
Copy link
Owner

@nktnet1 nktnet1 commented Mar 13, 2024

@pimterry follow up regarding "types" in #38.

I managed to get the types for @httptoolkit/esm published here:

Context: DefinitelyTyped/DefinitelyTyped#68976

The type definition for @httptoolkit/esm can thus be removed from import-sync.

This MR is an improvement to the solution in #81 to fix #79.


Also, given that the original esm repository has been archived, do you think it's a good idea to enable issues for the @httptoolkit/esm fork? (e.g. by following the instructions here).

@nktnet1 nktnet1 requested a review from pimterry March 13, 2024 23:38
@nktnet1 nktnet1 self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fab7eb1) to head (5b37d6c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           42        42           
  Branches         6         6           
=========================================
  Hits            42        42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pimterry
Copy link
Collaborator

I managed to get the types for @httptoolkit/esm published here

Nice work! That's definitely a good move.

Also, given that the original esm repository has been archived, do you think it's a good idea to enable issues for the @httptoolkit/esm fork? (e.g. by following the instructions here).

Done 👍

@nktnet1 nktnet1 merged commit d231cfb into main Mar 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to tic in CDK project
2 participants