Add Molecule GitHub workflow #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with parallel testing in GitHub actions.
parcimonic
force-pushed
the
add-molecule-workflow
branch
from
0241f31
to
de99634
Compare
|
The test for Red Hat is failing because my update to the image will only be built when Do you want me to move that commit to another PR or is it OK to leave it here? |
|
Awesome! Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This is the second PR for #19.
Some comments on my changes:
I had to update the Red Hat test image so DNF could work in Ansible. I couldn't find a
python39-dnfpackage, so I went with Ansible's suggestion ofpython3-dnf. With this change, tests are working fine now 🎉Molecule configuration now uses environment variables to select the test OS. Since for now you're using your self maintained images, I've changed only the "OS-name" part of the fully qualified image name. This keeps the test matrix "short", but it doesn't allow much flexibility if someone wants to test using images in other namespaces. I'm ok with that right now, but feel free to change the variable scope in the future if you wish.