Remove Windows-specific invocation of MagickCore-config#138
Merged
nlfiedler merged 2 commits intonlfiedler:masterfrom Sep 19, 2024
Merged
Remove Windows-specific invocation of MagickCore-config#138nlfiedler merged 2 commits intonlfiedler:masterfrom
nlfiedler merged 2 commits intonlfiedler:masterfrom
Conversation
Owner
|
Thank you, I'm happy to have the help with the Windows build, I've had a lot of trouble getting it to work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Windows-specific invocation of
MagickCore-configin build script.This was added in Support building with ImageMagick from MSYS2 #114 to support building on MSYS2, and modified in Enum and link fixes to enable building on Windows using MSVC #126 to address some issues of native ImageMagick-Windows build. However, the
not(target_env = "msvc")flag does not cover a scenario where ImageMagick and its dependencies are built and managed on MSYS2 while your own application is built with MSVC. Fortunately, with Add pkg-config as fallback for MagickCore-config #132 it is no longer needed, and on MSYS2 it just takes the fallback path.Uses ucrt64 instead of mingw64 in
test-msys2.yamlworkflow, as ucrt64 has fewer compatibility issues.Fixes Fail to build bindings: trait
From<f32>is not implemented foru16#137.